chore: rename all modules named test to tests
#1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
github-actions
bot
added
conductor
SuperFluffy
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
These are great.
In a future patch we should also break out the tests into free-standing files (at least for oversized modules).
And also merge https://github.com/astriaorg/astria/blob/33dae4256f7f6d1f936f9e0de166695be1bf416d/crates/astria-sequencer/src/app/tests_block_fees.rs and its sibling test modules into a folder structure under a common tests/ module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A trivial rename of some modules.
Background
It's canonical to name unit test modules as
tests. We currently have a mixture oftestandteststhroughout the codebase.Changes
testmodules totests. No actual tests were changed.